Add 'precision' setting for the NuGet package version #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please don't merge this yet, I've had an alternative idea to resolve #401 which I want to explore first |
AArnott
requested changes
Feb 12, 2022
For the test "CanSetPrecisionForNuGetPackageVersion", add test cases to verify the NuGet package version is computed correctly when a static prerelease tag is configured in version.json
Yes, I was referring to that conversation. This PR is ready to merge in my opinion.
I added some additional test cases with commit a6e4aeb |
AArnott
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
precisionsetting to thenugetPackageVersionsection inversion.jsonwhich defaults tobuild(keeping the existing default behavior).This allows configuring Nerdbank.GitVersioning to include a 4th version component by setting the precision to
revision.For completeness this also allows to include only the major and/or minor versions in the package version - though I do not know how useful this is.
Fixes #401