Honor AssemblyVersion as explicitly set in version.json #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he rest of the computed build version **Breaking change**: The `assemblyVersion.precision` property in the `version.json` file is now ignored if `assemblyVersion.version` is set to a non-null value. When set, `assemblyVersion.version` is taken literally. Specifying `assemblyVersion.precision` alone will still set the assembly version based on the ordinary computed `version` as it did before. The schema has been updated to reflect that specifying `assemblyVersion.version` *and* `assemblyVersion.precision` is an error. Fixes #703
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow AssemblyVersion to be set explicitly without being altered by the rest of the computed build version
Breaking change: The
assemblyVersion.precisionproperty in theversion.jsonfile is now ignored ifassemblyVersion.versionis set to a non-null value. When set,assemblyVersion.versionis taken literally.Specifying
assemblyVersion.precisionalone will still set the assembly version based on the ordinary computedversionas it did before.The schema has been updated to reflect that specifying
assemblyVersion.versionandassemblyVersion.precisionis an error.Fixes #703