Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed typo in ParentEnumerator.MoveNext and added corresponding tests #693

Merged
merged 1 commit into from Nov 23, 2021
Merged

Fixed typo in ParentEnumerator.MoveNext and added corresponding tests #693

merged 1 commit into from Nov 23, 2021

Conversation

GlebChili
Copy link
Contributor

@GlebChili GlebChili commented Nov 23, 2021 •
edited

Closes #694

@dnfadmin
Copy link

dnfadmin commented Nov 23, 2021 •
edited

CLA assistant check
All CLA requirements met.

@GlebChili GlebChili mentioned this pull request Nov 23, 2021
Closed
@GlebChili GlebChili marked this pull request as ready for review November 23, 2021 14:17
@AArnott AArnott changed the base branch from master to v3.4 November 23, 2021 16:47
@AArnott AArnott added this to the v3.4 milestone Nov 23, 2021
AArnott
AArnott approved these changes Nov 23, 2021
View reviewed changes
Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I rebased your source branch on v3.4 so we can service the current stable version rather than have your fix wait for a stable 3.5 release.

@AArnott
Copy link
Collaborator

AArnott commented Nov 23, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@AArnott AArnott merged commit 806360a into dotnet:v3.4 Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AArnott AArnott AArnott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.4
Development

Successfully merging this pull request may close these issues.

Typo in ManagedGit ParentEnumerator.MoveNext causes incorrect behavior and ArgumentOutOfRangeException
3 participants
@GlebChili @dnfadmin @AArnott