Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run 32-bit tests #632

Merged
merged 1 commit into from Jul 27, 2021
Merged

Run 32-bit tests #632

merged 1 commit into from Jul 27, 2021

Conversation

qmfrederik
Copy link
Contributor

@qmfrederik qmfrederik commented Jul 27, 2021 •
edited

Run tests on 32-bit .NET on Windows.

@qmfrederik
Copy link
Contributor Author

The crash during the 32-bit test is probably libgit2/libgit2sharp#1755 (libgit2/libgit2#5363 (comment)), likely fixed by libgit2/libgit2sharp@b78b290

@qmfrederik qmfrederik mentioned this pull request Jul 27, 2021
Merged
@AArnott
Copy link
Collaborator

AArnott commented Jul 27, 2021

@qmfrederik Any fixes are going to the v3.4 branch. master is for future feature development.
Consider rebasing and targeting v3.4 if this is to fix a bug or add tests that should pass on v3.4.

@qmfrederik
Copy link
Contributor Author

@AArnott Roger that, I'll rebase once #633 gets in.

AArnott
AArnott approved these changes Jul 27, 2021
View reviewed changes
Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm rebasing on v3.4 (actually on your other PR) so we can get this goodness into v3.4.

@AArnott AArnott changed the base branch from master to v3.4 July 27, 2021 14:01
@AArnott AArnott modified the milestones: v3.5, v3.4 Jul 27, 2021
@AArnott AArnott mentioned this pull request Jul 27, 2021
Merged
@qmfrederik qmfrederik marked this pull request as ready for review July 27, 2021 14:24
@AArnott AArnott enabled auto-merge July 27, 2021 14:51
@AArnott AArnott merged commit 41696ba into dotnet:v3.4 Jul 27, 2021
@qmfrederik qmfrederik deleted the features/32-bit-test branch July 28, 2021 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AArnott AArnott AArnott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@qmfrederik @AArnott