Include missing zlib compression level header checks #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AArnott
approved these changes
Jun 20, 2021
|
I'm rebasing your commits on |
|
Looks good! .NET 6 will have native ZlibStream support, so it may make sense to use that implementation when it ships: dotnet/runtime@d3beb60. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix nbgv failing for repos that have objects compressed with zlib levels 2-5 (header
0x78 0x5E) and 7-9 (0x78 0xDA). If required, I can embed zz files of different compression levels and implements tests for those.Fixes #619