Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch tests from 7z to zip and enable test #614

Merged
merged 2 commits into from Jun 12, 2021
Merged

Switch tests from 7z to zip and enable test #614

merged 2 commits into from Jun 12, 2021

Conversation

AArnott
Copy link
Collaborator

@AArnott AArnott commented Jun 12, 2021

Fixes #125

This not only gets us able to address #125, but allows the test to run on .NET Core runtimes as well, since the 7z library we were using only ran on net461.
The test from #125 is still broken though, on account of not regularly running.
Fixes #125 by enabling the test that now passes.
@AArnott AArnott added this to the v3.4 milestone Jun 12, 2021
@AArnott AArnott linked an issue Jun 12, 2021 that may be closed by this pull request
@AArnott AArnott merged commit 07964f8 into v3.4 Jun 12, 2021
@AArnott AArnott deleted the fix125 branch June 12, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unstable test: Submodule_RecognizedWithCorrectVersion
1 participant