Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't load git packs if the .pack file is missing #597

Merged
merged 3 commits into from Apr 29, 2021
Merged

Don't load git packs if the .pack file is missing #597

merged 3 commits into from Apr 29, 2021

Conversation

qmfrederik
Copy link
Contributor

Should contribute towards #583

AArnott
AArnott approved these changes Apr 29, 2021
View reviewed changes
Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@AArnott AArnott added this to the v3.4 milestone Apr 29, 2021
@AArnott
Copy link
Collaborator

AArnott commented Apr 29, 2021

@qmfrederik After this, should we ask the original reporter of the issue to test, or do you think more work is required?

@qmfrederik
Copy link
Contributor Author

@AArnott I think we can ask @ssa3512 for confirmation (but he may have already deleted the orphaned index file), other than that, I don't see much else we can do.

@AArnott AArnott changed the base branch from master to v3.4 April 29, 2021 17:20
@AArnott AArnott merged commit e3477ca into dotnet:v3.4 Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AArnott AArnott AArnott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@qmfrederik @AArnott