Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 3rdPartyNotices to package #593

Closed
AArnott opened this issue Apr 22, 2021 · 1 comment
Closed

Add 3rdPartyNotices to package #593

AArnott opened this issue Apr 22, 2021 · 1 comment
Assignees
@AArnott
Milestone
v3.4

Comments

@AArnott
Copy link
Collaborator

AArnott commented Apr 22, 2021

Now that you are shipping additional Microsoft DLLs in the nupkg, I wonder whether they require adding some legal text as well. Perhaps it is enough that the version resources of the DLLs themselves carry Microsoft copyright notices, and that Nerdbank.GitVersioning.nuspec contains <license type="expression">MIT</license> which apparently matches how Microsoft licenses those DLLs.

Originally posted by @KalleOlaviNiemitalo in #589 (comment)

We should look at other 3rd party files that are included in the package (if any) as well.
@KalleOlaviNiemitalo KalleOlaviNiemitalo mentioned this issue May 30, 2021
Closed
@AArnott AArnott self-assigned this May 30, 2021
AArnott added a commit that referenced this issue May 30, 2021
@AArnott
Add 3rd party notices to repo and deployed packages
443d422 
Closes #593
@AArnott AArnott added this to the v3.4 milestone May 30, 2021
@AArnott
Copy link
Collaborator Author

AArnott commented May 30, 2021

Closed by 443d422

@AArnott AArnott closed this as completed May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AArnott AArnott

Labels
None yet
Projects
None yet
Milestone
v3.4
Development

No branches or pull requests
1 participant
@AArnott