ExcludeFromCodeCoverage is inaccessible due to its protection level (version 3.3.37)

[NightOwl888]

I tried upgrading from 3.0.28 to 3.3.37, but started getting this error.

error CS0122: 'ExcludeFromCodeCoverageAttribute' is inaccessible due to its protection level

The problem appears to be compilation constants on the generated file for this attribute:

#if NETFRAMEWORK || NETCOREAPP || NETSTANDARD2_0 || NETSTANDARD2_1
[System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
#endif

.NET Core 1.x does not support ExcludeFromCodeCoverage attribute, so the constants should be changed to:

#if NETFRAMEWORK || NETCOREAPP2_0 || NETCOREAPP2_1 || NETCOREAPP2_2 || NETCOREAPP3_0 || NETCOREAPP3_1 || NETSTANDARD2_0 || NETSTANDARD2_1
[System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
#endif

Note that .NET 5.x is also missing from the list.

[AArnott]

The .NET Core 1.x failing bit is a duplicate of #452. .NET Core 1.x is out of Microsoft support so it's not interesting to support out here either.
We should do the right thing for .NET 5 though.

[NightOwl888]

Out of support, yes. But still the easiest way to test .NET Standard 1.x support.

Since there are not likely to be any more frameworks that do not support ExcludeFromCodeCoverageAttribute beyond .NET Core 1.x and .NET Standard 1.x, it would probably be better just to exclude the attribute in those cases and include it in all other cases.

#if NETSTANDARD1_0 || NETSTANDARD1_1 || NETSTANDARD1_2 || NETSTANDARD1_3 || NETSTANDARD1_4 || NETSTANDARD1_5 || NETSTANDARD1_6 || NETCOREAPP1_0 || NETCOREAPP1_1
#else
[System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
#endif

.NET 6 is coming out next year and the plan is to release a new major version every year after that, so this would help to future-proof.

[AArnott]

Well, if you want to send a PR to fix both cases, that's fine.
But using the positive test rather than the negative is fine too (even preferable) because starting with NET5_0, they're going to keep defining that symbol even post-5.0.

[KalleOlaviNiemitalo]

starting with NET5_0, they're going to keep defining that symbol even post-5.0.

It looks like that plan was changed in dotnet/sdk#13377 and dotnet/sdk#14798; they're going to define NET5_0_OR_GREATER instead.

[AArnott]

That's great to hear, @KalleOlaviNiemitalo. Thanks for sharing.