set-env disabled for Github Actions

[kamronbatman]

Github has disabled set-env:

Nerdbank.GitVersioning/azure-pipelines/Set-EnvVars.ps1

Line 49 in 57a4826

Write-Host "::set-env name=$($_.Key)::$($_.Value)"

So builds that use NBGV for versioning are failing.

More info:
GHSA-mfwh-5m23-j46w
https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

[AArnott]

Thanks, @kamronbatman. In fact the symptom you describe that nbgv builds are failing is not due to this code location. That symptom is already fixed in #516. If you're still seeing this in your github workflow, make sure you're using the latest version of Nerdbank.GitVersioning and/or the dotnet/nbgv github Action.

As this repo does not build on GitHub Actions, the code location you call out is not actually impacting anything. It's merely there because this script is shared across many repos. The master location of this script was updated recently so this repo will get an update eventually when I copy over the latest script.

[kamronbatman]

Not sure why then but I am having that issue with the newest github actions version. It stopped erroring when I turned off setting the variables in version.json. hmm

[AArnott]

@kamronbatman The version.json file does not impact behavior of the dotnet/nbgv Action as far as setting paths or environment variables. So if changing that file fixed it, you likely have a Nerdbank.GitVersioning package reference in your repo somewhere that needs to be updated as well.

[kamronbatman]

EDIT:
Somehow one of my project files actually has an outdated reference like you said! I am surprised I didn't notice this.

Thanks!