Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Arch Linux runtime ID #476

Merged
merged 7 commits into from May 16, 2020
Merged

Add Arch Linux runtime ID #476

merged 7 commits into from May 16, 2020

Conversation

JamieMagee
Copy link
Member

The Arch Linux runtime id was added to the .NET runtime in this commit, which suggests that it should be compatible with the linux-x64 native dependencies.

I would appreciate some input on the best way to test this out locally

The Arch Linux runtime id was added to the .NET runtime in [this commit](dotnet/runtime@00d8f8e), which suggests that it should be compatible with the `linux-x64` native dependencies.

I would appreciate some input on the best way to test this out locally
@AArnott
Copy link
Collaborator

AArnott commented May 12, 2020

Thanks for contributing!

Testing locally would involve a docker container.
And similarly, what I would want with this PR is the addition of a new test job in our Azure Pipeline to help ensure that it works and keeps working. Can you add that test job? You can follow the pattern here:

- job: Ubuntu_Disco
dependsOn: Windows
pool:
vmImage: Ubuntu 16.04 # not a bug. we always use this pool, but use containers for the specific version
container: disco
steps:
- template: azure-pipelines/xplattest-pipeline.yml

@dnfclas
Copy link

dnfclas commented May 12, 2020

CLA assistant check
All CLA requirements met.

@JamieMagee
Copy link
Member Author

@AArnott So I can test this locally, but I'm struggling with the CI.

I'm trying to run pacman -Sy --noconfirm git dotnet-sdk and this passes locally, but when running in Azure DevOps it gives the error

you cannot perform this operation unless you are root.

But the ArchLinux docker image doesn't ship with sudo by default. I think it might be the same issue as microsoft/azure-pipelines-agent#2043.

Do you have any suggestions? Or would you accept a PR if I tried this on GitHub Actions?

@AArnott
Copy link
Collaborator

AArnott commented May 14, 2020

I have similarly complained when docker images lacked a sudo command and Azure Pipelines didn't give you root access.
I'll take a look.
Worst case scenario: we add a layer to that Arch Linux image that adds sudo and consume that from this pipeline.

@AArnott
Copy link
Collaborator

AArnott commented May 14, 2020

With my added commit, we're getting farther. But it fails likely due to missing native dependencies. Did you say it's working in your local testing? What prereqs are you adding to the image when it works for you?

@JamieMagee
Copy link
Member Author

I was missing the openssl-1.0 package. Thanks for the help! It works now 😄

@JamieMagee
Copy link
Member Author

@AArnott Do you have time today to take another look at this?

Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AArnott AArnott merged commit 96d7f7f into dotnet:master May 16, 2020
@JamieMagee JamieMagee deleted the arch-linux-support branch May 19, 2020 19:43
@JamieMagee
Copy link
Member Author

@AArnott thanks for merging. Is it possible to release a stable version to NuGet with this fix?

@AArnott
Copy link
Collaborator

AArnott commented May 20, 2020

I can, but I tend to leave prereleases open for longer to collect more new features.
Is there some reason you need a stable version as opposed to a prerelease on nuget.org? It shouldn't impact any of your downstream users since it's a PrivateAssets="all" package reference that doesn't appear to your own users.

@JamieMagee
Copy link
Member Author

I think we'd prefer to depend on a stable version, rather than a pre-release version. But, I'll open a PR and get some feedback on if a beta version is acceptable.

@AArnott
Copy link
Collaborator

AArnott commented May 20, 2020

NB.GV is generally "stable" nowadays. I don't think we'll do anything to really destabilize without a major version bump at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants