New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Arch Linux runtime ID #476
Conversation
The Arch Linux runtime id was added to the .NET runtime in [this commit](dotnet/runtime@00d8f8e), which suggests that it should be compatible with the `linux-x64` native dependencies. I would appreciate some input on the best way to test this out locally
Thanks for contributing! Testing locally would involve a docker container. Nerdbank.GitVersioning/azure-pipelines.yml Lines 188 to 195 in d46ca3a
|
@AArnott So I can test this locally, but I'm struggling with the CI. I'm trying to run
But the ArchLinux docker image doesn't ship with Do you have any suggestions? Or would you accept a PR if I tried this on GitHub Actions? |
I have similarly complained when docker images lacked a |
With my added commit, we're getting farther. But it fails likely due to missing native dependencies. Did you say it's working in your local testing? What prereqs are you adding to the image when it works for you? |
I was missing the |
@AArnott Do you have time today to take another look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@AArnott thanks for merging. Is it possible to release a stable version to NuGet with this fix? |
I can, but I tend to leave prereleases open for longer to collect more new features. |
I think we'd prefer to depend on a stable version, rather than a pre-release version. But, I'll open a PR and get some feedback on if a beta version is acceptable. |
NB.GV is generally "stable" nowadays. I don't think we'll do anything to really destabilize without a major version bump at this point. |
The Arch Linux runtime id was added to the .NET runtime in this commit, which suggests that it should be compatible with the
linux-x64
native dependencies.I would appreciate some input on the best way to test this out locally