Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow suppressing ThisAssembly class generation via EmitThisAssemblyClass msbuild property #472

Merged
merged 1 commit into from Apr 29, 2020
Merged

Allow suppressing ThisAssembly class generation via EmitThisAssemblyClass msbuild property #472

merged 1 commit into from Apr 29, 2020

Conversation

paulomorgado
Copy link
Contributor

@paulomorgado paulomorgado commented Apr 29, 2020 •
edited by AArnott

Closes #292

AArnott
AArnott requested changes Apr 29, 2020
View reviewed changes
Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. Thanks for filling this in.

src/Nerdbank.GitVersioning.Tasks/build/Nerdbank.GitVersioning.targets Outdated Show resolved Hide resolved
@paulomorgado
Add this ThisAssemblyClass property to AssemblyVersionInfo class to c…
e41c54c 
…ontrol generation of the ThisAssembly class.
AArnott
AArnott approved these changes Apr 29, 2020
View reviewed changes
Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AArnott AArnott changed the title Add this ThisAssemblyClass property to AssemblyVersionInfo class to control generation of the ThisAssembly class. Allow suppressing ThisAssembly class generation via EmitThisAssemblyClass msbuild property Apr 29, 2020
@AArnott AArnott added this to the v3.1 milestone Apr 29, 2020
@AArnott AArnott merged commit d7a4eb4 into dotnet:master Apr 29, 2020
@AArnott AArnott modified the milestones: v3.1, v3.2 May 2, 2020
@AArnott AArnott mentioned this pull request Jul 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AArnott AArnott AArnott approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v3.2
Development

Successfully merging this pull request may close these issues.

optional ThisAssembly generation
2 participants
@paulomorgado @AArnott