Set BuildingRef as output property from GetBuildVersion #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
AArnott
requested changes
Apr 28, 2020
aok-foss
force-pushed
the
output-buildref
branch
from
7ee1cbf
to
60bf406
Compare
AArnott
reviewed
May 2, 2020
AArnott
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not a good idea to take a dependency on a branch name. At the same time, branches are too useful to ignore. The
PublicReleasefunctionality depends on them.The argument can go one step further: during development (in non-public releases), branch names in version numbers are useful for traceability: e.g.
1.0.0-g1234567+PR1512or1.0.0-g1234567+BalpineLinuxIt would be easiest to extend NBGV-produced version numbers in the way above if NBGV also provided access to build refs.