Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code sign in CI builds #446

Merged
merged 1 commit into from Mar 9, 2020
Merged

Code sign in CI builds #446

merged 1 commit into from Mar 9, 2020

Conversation

AArnott
Copy link
Collaborator

@AArnott AArnott commented Mar 9, 2020

CC: @onovotny

@dnfclas
Copy link

dnfclas commented Mar 9, 2020

CLA assistant check
All CLA requirements met.

@clairernovotny
Copy link
Member

One suggestion is to split the build and sign into separate stages (like the sample repo) to minimize any possible exposure of the secrets during the build. Since the secrets in the variable group aren't in the build phase, things like binlogs won't accidently contain them.

@AArnott
Copy link
Collaborator Author

AArnott commented Mar 9, 2020

It's a fair point, @onovotny. But I'm using a 'secret' variable anyway, so it's not available to any tool unless I explicitly pass it in from the YAML file. You can see in the binlog file that only the username is available.

image

@AArnott AArnott merged commit 776bf99 into master Mar 9, 2020
@AArnott AArnott deleted the codesign branch March 9, 2020 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants