Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cake CoreCLR fix #434

Merged
merged 4 commits into from Mar 8, 2020
Merged

Cake CoreCLR fix #434

merged 4 commits into from Mar 8, 2020

Conversation

starkcolin
Copy link
Contributor

Fixes #365

The native binaries are now included in the Cake.GitVersioning NuGet package, like they are in the Nerdbank.GitVersioning NuGet package, but with a different structure.
Unlike the main project, which uses a nuspec file, this uses only the csproj file.

Despite the fact that the directory containing the native binary was successfully added to the PATH, the Cake addin was still throwing a DllNotFoundException. I got around this by using the existing native binary locator and copying the native DLL to the root of the Cake addin at runtime.

Have successfully tested using NetFx, and NetCore & Mono on both Windows & Linux. There are no automated tests because none existed for the Cake addin.

@AArnott AArnott merged commit d383815 into dotnet:master Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility with Cake CoreCLR
2 participants