Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unstable test: Submodule_RecognizedWithCorrectVersion #125

Closed
AArnott opened this issue May 29, 2017 · 3 comments · Fixed by #614
Closed

Unstable test: Submodule_RecognizedWithCorrectVersion #125

AArnott opened this issue May 29, 2017 · 3 comments · Fixed by #614
Assignees
@AArnott

Comments

@AArnott
Copy link
Collaborator

AArnott commented May 29, 2017

The VersionOracleTests.Submodule_RecognizedWithCorrectVersion test frequently fails with this output:

    VersionOracleTests.Submodule_RecognizedWithCorrectVersion [FAIL]
      System.ComponentModel.Win32Exception : The system cannot find the file specified
      Stack Trace:
           at System.Diagnostics.Process.StartWithCreateProcess(ProcessStartInfo startInfo)
           at System.Diagnostics.Process.Start()
           at SevenZipNET.WProcess.Execute()
           at SevenZipNET.SevenZipExtractor.ExtractAll(String destination, Boolean overwrite, Boolean keepStructure)
        src\NerdBank.GitVersioning.Tests\TestUtilities.cs(70,0): at Nerdbank.GitVersioning.Tests.TestUtilities.ExtractRepoArchive(String repoArchiveName)
        src\NerdBank.GitVersioning.Tests\VersionOracleTests.cs(18,0): at VersionOracleTests.Submodule_RecognizedWithCorrectVersion()

It causes PR builds to fail frequently.
@AArnott AArnott self-assigned this May 29, 2017
@clairernovotny
Copy link
Member

Seems like this can be closed now with your recent commit.

@AArnott
Copy link
Collaborator Author

AArnott commented Jun 8, 2017

Closed by e1be204

@AArnott AArnott closed this as completed Jun 8, 2017
@AArnott AArnott mentioned this issue Jun 17, 2017
Merged
AArnott added a commit that referenced this issue Jun 17, 2017
@AArnott
Skip Submodule_RecognizedWithCorrectVersion test due to #125
f815bb3
@AArnott AArnott reopened this Jun 17, 2017
@AArnott
Copy link
Collaborator Author

AArnott commented Jun 17, 2017

It's still happening.

AArnott added a commit that referenced this issue Jun 23, 2017
@AArnott
Skip Submodule_RecognizedWithCorrectVersion test due to #125
76d99a4
AArnott added a commit that referenced this issue Jun 12, 2021
@AArnott
Switch from 7z to zip for test archive
ed2759e 
This not only gets us able to address #125, but allows the test to run on .NET Core runtimes as well, since the 7z library we were using only ran on net461.
The test from #125 is still broken though, on account of not regularly running.
AArnott added a commit that referenced this issue Jun 12, 2021
@AArnott
Fix up submodule handling in managed git
daa0303 
Fixes #125 by enabling the test that now passes.
@AArnott AArnott mentioned this issue Jun 12, 2021
Merged
@AArnott AArnott linked a pull request Jun 12, 2021 that will close this issue
Switch tests from 7z to zip and enable test #614
Merged
@AArnott AArnott closed this as completed Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AArnott AArnott

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch tests from 7z to zip and enable test dotnet/Nerdbank.GitVersioning
2 participants
@AArnott @clairernovotny