From 9e74f1e35cebd630783461d272df111c4024aa1f Mon Sep 17 00:00:00 2001
From: Andrew Arnott <andrewarnott@live.com>
Date: Thu, 15 Apr 2021 08:21:44 -0600
Subject: [PATCH] Include BCL assemblies required for VS 2017 build tools

Several assemblies are required by this msbuild task but are not included in MSBuild 2017.

Adding the assemblies to the package alone is not enough, since binding redirects are also missing in msbuild.exe.config. We make up for this with a custom assembly resolver.

Fixes #589
---
 azure-pipelines.yml                           |  8 ++--
 global.json                                   |  2 +-
 src/Directory.Build.props                     |  2 +-
 .../AssemblyLoader.cs                         | 48 +++++++++++++++++++
 .../Nerdbank.GitVersioning.nuspec             |  7 ++-
 5 files changed, 59 insertions(+), 8 deletions(-)
 create mode 100644 src/Nerdbank.GitVersioning.Tasks/AssemblyLoader.cs

diff --git a/azure-pipelines.yml b/azure-pipelines.yml
index c3a113fd..46dee667 100644
--- a/azure-pipelines.yml
+++ b/azure-pipelines.yml
@@ -58,10 +58,10 @@ stages:
       displayName: Configure git commit author for testing
 
     - task: UseDotNet@2
-      displayName: Install .NET Core SDK 5.0.100
+      displayName: Install .NET Core SDK 5.0.202
       inputs:
         packageType: sdk
-        version: 5.0.100
+        version: 5.0.202
 
     - task: UseDotNet@2
       displayName: Install .NET Core 3.1
@@ -306,10 +306,10 @@ stages:
         packageType: sdk
         version: 3.1.100
     - task: UseDotNet@2
-      displayName: Install .NET Core SDK 5.0.100
+      displayName: Install .NET Core SDK 5.0.202
       inputs:
         packageType: sdk
-        version: 5.0.100
+        version: 5.0.202
     - script: dotnet --info
       displayName: Show dotnet SDK info
     - bash: |
diff --git a/global.json b/global.json
index ee8f712f..66a8a8b2 100644
--- a/global.json
+++ b/global.json
@@ -1,5 +1,5 @@
 {
   "sdk": {
-    "version": "5.0.100"
+    "version": "5.0.202"
   }
 }
diff --git a/src/Directory.Build.props b/src/Directory.Build.props
index 4921af4e..0757e8d2 100644
--- a/src/Directory.Build.props
+++ b/src/Directory.Build.props
@@ -4,7 +4,7 @@
     <BaseIntermediateOutputPath>$(MSBuildThisFileDirectory)..\obj\$(MSBuildProjectName)\</BaseIntermediateOutputPath>
     <OutputPath>$(MSBuildThisFileDirectory)..\bin\$(MSBuildProjectName)\$(Configuration)\</OutputPath>
     <DocumentationRootFolder>$(MSBuildThisFileDirectory)..\wiki\api</DocumentationRootFolder>
-    <LangVersion>8.0</LangVersion>
+    <LangVersion>9.0</LangVersion>
 
     <SignAssembly>true</SignAssembly>
     <AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)strongname.snk</AssemblyOriginatorKeyFile>
diff --git a/src/Nerdbank.GitVersioning.Tasks/AssemblyLoader.cs b/src/Nerdbank.GitVersioning.Tasks/AssemblyLoader.cs
new file mode 100644
index 00000000..55da8b8b
--- /dev/null
+++ b/src/Nerdbank.GitVersioning.Tasks/AssemblyLoader.cs
@@ -0,0 +1,48 @@
+#if NETFRAMEWORK
+
+using System;
+using System.IO;
+using System.Reflection;
+using System.Runtime.CompilerServices;
+
+namespace System.Runtime.CompilerServices
+{
+    [AttributeUsage(AttributeTargets.Method, AllowMultiple = false)]
+    public sealed class ModuleInitializerAttribute : Attribute { }
+}
+
+namespace Nerdbank.GitVersioning.Tasks
+{
+    internal static class AssemblyLoader
+    {
+        [ModuleInitializer]
+        internal static void LoaderInitializer()
+        {
+            AppDomain.CurrentDomain.AssemblyResolve += CurrentDomain_AssemblyResolve;
+        }
+
+        private static Assembly CurrentDomain_AssemblyResolve(object sender, ResolveEventArgs args)
+        {
+            try
+            {
+                var required = new AssemblyName(args.Name);
+                string path = Path.Combine(Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location), required.Name + ".dll");
+                if (File.Exists(path))
+                {
+                    AssemblyName actual = AssemblyName.GetAssemblyName(path);
+                    if (actual.Version >= required.Version)
+                    {
+                        return Assembly.LoadFile(path);
+                    }
+                }
+            }
+            catch
+            {
+            }
+
+            return null;
+        }
+    }
+}
+
+#endif
diff --git a/src/Nerdbank.GitVersioning.Tasks/Nerdbank.GitVersioning.nuspec b/src/Nerdbank.GitVersioning.Tasks/Nerdbank.GitVersioning.nuspec
index b260a210..30e035fc 100644
--- a/src/Nerdbank.GitVersioning.Tasks/Nerdbank.GitVersioning.nuspec
+++ b/src/Nerdbank.GitVersioning.Tasks/Nerdbank.GitVersioning.nuspec
@@ -23,10 +23,13 @@ IMPORTANT: The 3.x release may produce a different version height than prior maj
     <file src="$BaseOutputPath$net461\NerdBank.GitVersioning.dll" target="build\MSBuildFull\NerdBank.GitVersioning.dll" />
     <file src="$BaseOutputPath$net461\Nerdbank.GitVersioning.Tasks.dll" target="build\MSBuildFull\Nerdbank.GitVersioning.Tasks.dll" />
     <file src="$BaseOutputPath$net461\Newtonsoft.Json.dll" target="build\MSBuildFull\Newtonsoft.Json.dll" />
+    <file src="$BaseOutputPath$net461\PInvoke.Kernel32.dll" target="build\MSBuildFull\PInvoke.Kernel32.dll" />
+    <file src="$BaseOutputPath$net461\System.Buffers.dll" target="build\MSBuildFull\System.Buffers.dll" />
+    <file src="$BaseOutputPath$net461\System.Memory.dll" target="build\MSBuildFull\System.Memory.dll" />
+    <file src="$BaseOutputPath$net461\System.Numerics.Vectors.dll" target="build\MSBuildFull\System.Numerics.Vectors.dll" />
+    <file src="$BaseOutputPath$net461\System.Runtime.CompilerServices.Unsafe.dll" target="build\MSBuildFull\System.Runtime.CompilerServices.Unsafe.dll" />
     <file src="$BaseOutputPath$net461\System.Text.Json.dll" target="build\MSBuildFull\System.Text.Json.dll" />
     <file src="$BaseOutputPath$net461\Validation.dll" target="build\MSBuildFull\Validation.dll" />
-    <file src="$BaseOutputPath$net461\System.Runtime.CompilerServices.Unsafe.dll" target="build\MSBuildFull\System.Runtime.CompilerServices.Unsafe.dll" />
-    <file src="$BaseOutputPath$net461\PInvoke.Kernel32.dll" target="build\MSBuildFull\PInvoke.Kernel32.dll" />
     <file src="$LibGit2SharpNativeBinaries$runtimes\**" target="build\runtimes\" />
 
     <!-- Additional copies to work around DllNotFoundException on Mono (https://github.com/dotnet/Nerdbank.GitVersioning/issues/222) -->