Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Environment Variables in JSON output in easier-to-parse form #2506

Open
edyoung opened this issue Jan 14, 2024 · 2 comments
Open

Include Environment Variables in JSON output in easier-to-parse form #2506

edyoung opened this issue Jan 14, 2024 · 2 comments
Assignees

Comments

@edyoung
Copy link

edyoung commented Jan 14, 2024

If I run a set of benchmarks with

dotnet run -c:Release -- -f *Log* --runtimes net8.0 --envVars x:1 y:2

And export a JSON report, the JSON contains the environment variables embedded in the DisplayInfo:

"DisplayInfo":"LogBenchmark.TrackTrace: Job-OTYZFP(EnvironmentVariables=x=1,y=2, Runtime=.NET 8.0, Toolchain=net8.0, IterationCount=3, LaunchCount=1, WarmupCount=3)"

But I would like to be able to extract the environment variable values more easily from the report for further processing. What if there was an additional property bag in the report?

Something like:

 "EnvironmentVars": {
    "x": "1",
    "y:" "2"
  }
@adamsitnik
Copy link
Member

I am supportive of this idea. Please go ahead and send a PR.

@edyoung
Copy link
Author

edyoung commented Jan 28, 2024

The linked PR is complete afaik but needs a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants