Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FromUrl and FromSource more friendly #1910

Conversation

YegorStepanov
Copy link
Contributor

1st commit

Change unhandled exception with message exception.
Add Unsupported checking directly to the methods, because It fails in .NET core (and they are public).

2nd commit

Hide it from IntelliSense cuz it not working and not recommended. Feel free to drop the commit if it isn't desired.

3rd commit

Change unhandled exception with message-exception for the case:

BenchmarkRunner.Run(typeof(GenericBenchmarkType<>));

#1908

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @YegorStepanov !

@adamsitnik adamsitnik merged commit 6bb61ce into dotnet:master Aug 24, 2022
@YegorStepanov YegorStepanov deleted the make-FromUrl-and-FromSource-more-friendly branch August 24, 2022 20:45
@AndreyAkinshin AndreyAkinshin added this to the v0.13.2 milestone Aug 26, 2022
@YegorStepanov
Copy link
Contributor Author

Ah, for some reason I thought that [EditorBrowsable(EditorBrowsableState.Never)] works in Rider, but no.

Issue: dotnet/roslyn#4434

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants