Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy GC settings from host process #1765

Merged
merged 4 commits into from Aug 4, 2021
Merged

Conversation

adamsitnik
Copy link
Member

We have been always recognizing the settings of the Host process:

Register(GcMode.ServerCharacteristic, () => HostEnvironmentInfo.GetCurrent().IsServerGC);
Register(GcMode.ConcurrentCharacteristic, () => HostEnvironmentInfo.GetCurrent().IsConcurrentGC);

But for some reason we have never re-applied them to benchmark process. Which could cause a confusion in cases where users apply things like:

<ServerGarbageCollection>true</ServerGarbageCollection>

in their project file.

Reported offline by @stephentoub

@adamsitnik adamsitnik added this to the v0.13.1 milestone Aug 4, 2021
@adamsitnik adamsitnik merged commit 8f81b5b into master Aug 4, 2021
@adamsitnik adamsitnik deleted the copyGcSettingsFromHostProcess branch August 4, 2021 16:00
@stephentoub
Copy link
Member

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants