Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Add WasmMainJSPath in interpreter projects #1757

Conversation

radekdoulik
Copy link
Member

This should fix errors like:

performance/tools/dotnet/x64/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/6.0.0-rc.1.21378.3/Sdk/WasmApp.targets(139,5): error : $(WasmMainJSPath) property needs to be set

This sohuld fix errors like:

    performance/tools/dotnet/x64/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/6.0.0-rc.1.21378.3/Sdk/WasmApp.targets(139,5): error : $(WasmMainJSPath) property needs to be set
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the fix @radekdoulik

@adamsitnik adamsitnik merged commit 1a94d4d into dotnet:master Jul 29, 2021
@adamsitnik adamsitnik added this to the v0.13.1 milestone Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants