Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add eslint-plugin-eslint-plugin #616

Merged
merged 1 commit into from
Sep 20, 2021
Merged

feat: add eslint-plugin-eslint-plugin #616

merged 1 commit into from
Sep 20, 2021

Conversation

dimaMachina
Copy link
Owner

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Sep 9, 2021 •
edited

⚠️ No Changeset found

Latest commit: b8def4b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@theguild-bot
Copy link
Collaborator

theguild-bot commented Sep 9, 2021 •
edited

The latest changes of this PR are not available as alpha, since there are no linked changesets for this PR.

dimaMachina
dimaMachina commented Sep 9, 2021
View reviewed changes
package.json
@@ -13,7 +13,7 @@
"scripts": {
"generate:docs": "ts-node scripts/generate-docs.ts",
"postinstall": "patch-package",
"lint": "eslint --config .eslintrc.json --ext ts,js .",
"lint": "eslint --ignore-path .gitignore --ext ts,js .",
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to have .eslintignore file, because .gitignore file already contain ignored files and folders

dimaMachina
dimaMachina commented Sep 9, 2021
View reviewed changes
packages/plugin/package.json
"bob-the-bundler": "1.5.1",
"graphql": "15.5.3",
"typescript": "4.4.2",
"@types/lodash.camelcase": "4.3.6"
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, we need to have @types/lodash.lowercase and not @types/lodash.camelcase

dimaMachina
dimaMachina commented Sep 9, 2021
View reviewed changes
packages/plugin/tests/avoid-typename-prefix.spec.ts
}
`,
},
/* GraphQL */ `
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's nice to have test-case-shorthand-strings rule enabled

@dimaMachina dimaMachina marked this pull request as ready for review September 9, 2021 19:51
@dotansimha dotansimha merged commit 75165c6 into master Sep 20, 2021
@dotansimha dotansimha deleted the add-eslint-plugin-eslint-plugin branch September 20, 2021 05:45
@dotansimha
Copy link
Collaborator

I love it, thanks @B2o5T

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotansimha dotansimha dotansimha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dimaMachina @theguild-bot @dotansimha