Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preResolveTypes refers to wrong type (missing array) #2159

Closed
SimenB opened this issue Jul 12, 2019 · 2 comments
Closed

preResolveTypes refers to wrong type (missing array) #2159

SimenB opened this issue Jul 12, 2019 · 2 comments
Labels
plugins waiting-for-release Fixed/resolved, and waiting for the next stable release

Comments

@SimenB
Copy link
Contributor

SimenB commented Jul 12, 2019

Describe the bug

When using the new preResolveTypes config option, the generated types lose their Array in fragments.

To Reproduce
Steps to reproduce the behavior:

https://codesandbox.io/embed/graphql-codegen-preresolvetypes-bug-5c821

Expected behavior

export type ThingItemFragment = {
  __typename?: 'Thing';
  requirements: { __typename?: 'Requirements'; unmetRequirements: Array<Requirement> };
};

Environment:

  • OS: macOS
  • @graphql-codegen/...: 1.4.0
  • NodeJS: 10.16.0

Additional context
@ghost ghost mentioned this issue Jul 15, 2019
Closed
@dotansimha
Copy link
Owner

Fixed in #2270

@dotansimha dotansimha added the waiting-for-release Fixed/resolved, and waiting for the next stable release label Aug 1, 2019
@dotansimha
Copy link
Owner

Fixed in 1.5.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
plugins waiting-for-release Fixed/resolved, and waiting for the next stable release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SimenB @dotansimha