Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify what to do in case of conflict #16

Open
plexus opened this issue Feb 16, 2024 · 1 comment
Open

Clarify what to do in case of conflict #16

plexus opened this issue Feb 16, 2024 · 1 comment

Comments

@plexus
Copy link

plexus commented Feb 16, 2024

I'm very happy to see this initiative, as a tool author I was looking to see if something like this existed. I'm happy it does, and I'll be adopting this for starters in Kaocha, a test runner for Clojure.

One thing that I think would be worth stating explicitly is how tools should behave if a config file exists both at the top level of the project and in . config

Reasonable options

  • show an error message and exit
  • top level takes precedence (with warning?)
  • .config takes precedence (with warning?)
  • they are merged (in a specified order), if that makes sense for the tool
@bbatsov
Copy link

bbatsov commented Feb 16, 2024

I was just thinking about this myself (for RuboCop) and there it made most sense to have the top-level take precedence (just because you can have it's configuration at every level of a directory structure), but for most cases I think it'd be best to go with option 1 as the safest one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants