Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nil check operator in token checking at token introspection #1243

Merged
merged 1 commit into from Apr 10, 2019

Conversation

linhdangduy
Copy link
Contributor

Summary

#1242 fix

@nbulaj nbulaj self-requested a review April 10, 2019 07:30
@nbulaj nbulaj added this to the 5.1 milestone Apr 10, 2019
Copy link
Member

@nbulaj nbulaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚝

Could you please add a news entry and then squash you commits to a single one as bot suggested? Thanks for your contribution ❤️

@linhdangduy
Copy link
Contributor Author

@nbulaj
I have just add NEWS.md and fix typo of one test. Is that ok?
Should I write test for this change?

@nbulaj
Copy link
Member

nbulaj commented Apr 10, 2019

@linhdangduy it would be great to have a test for such case, so yes if you can

Copy link

@truongnmt truongnmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@linhdangduy
Copy link
Contributor Author

@nbulaj I added the test for this case. Is that clear?

@nbulaj
Copy link
Member

nbulaj commented Apr 10, 2019

@linhdangduy yep, thanks!

@nbulaj nbulaj merged commit 07a3e17 into doorkeeper-gem:master Apr 10, 2019
@linhdangduy linhdangduy deleted the add_nil_check_operator branch May 29, 2019 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants