Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explaining foreign key options for resource owner in a single place #1241

Merged
merged 1 commit into from Apr 6, 2019
Merged

Explaining foreign key options for resource owner in a single place #1241

merged 1 commit into from Apr 6, 2019

Conversation

felipeelias
Copy link
Member

@felipeelias felipeelias commented Apr 6, 2019 •
edited

Summary

  1. Add bit better explanation on how to add foreign keys to users on initial migration
  2. Change resource_owner to references
  3. Add non-null application reference in access_tokens

@felipeelias felipeelias changed the title Favor foreign_key option instead of add_foreign_key Explaining foreign key options for resource owner in a single place Apr 6, 2019
@felipeelias
Copy link
Member Author

I wanted to take advantage of foreign_key option on migration, but it turns out that doesn't work since the table name (oauth_applications) does not match with references :application.

Due to that, I just updated comments + spacing

nbulaj
nbulaj approved these changes Apr 6, 2019
View reviewed changes
Copy link
Member

@nbulaj nbulaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@felipeelias
Explaining foreign key options for resource owner in a single place
67df12c 
+ Spacing changes
+ Non-null application reference in oauth_access_tokens
@felipeelias felipeelias merged commit 9bb03f8 into master Apr 6, 2019
@felipeelias felipeelias deleted the migration-updates branch April 6, 2019 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbulaj nbulaj nbulaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@felipeelias @nbulaj