New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is this unused
false positive?
#942
Labels
Comments
Can reproduce, looking into it. |
dominikh
added
started
Issues we've started working on
and removed
needs-triage
Newly filed issue that needs triage
labels
Mar 5, 2021
This should be fixed on master. I'd like to wait a day or two, to see if this change has caused any new bugs. If it hasn't, I'll make a new patch release. |
I see! Thank you for quick response! |
dominikh
added a commit
that referenced
this issue
Mar 9, 2021
In 41bedbd we incorrectly decided that unused no longer needed to deduplicate types. For the most part, this was correct. However, it failed to account for pointer types. go/types does not guarantee that types.NewPointer(T) == types.NewPointer(T). This caused parts of the graph to be incorrectly unreachable. This commit reverts the aforementioned commit, but puts our custom Map in its own package, only to be used by the 'unused' check. Closes gh-942 (cherry picked from commit 9680b43)
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi, I have a question.
Is this a false positive?
Static checker warns
unused
function.This private function is used through interface.
This problem happens with golangci-lint@v1.38.0, not with golangci-lint@v1.37.1.
The text was updated successfully, but these errors were encountered: