New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
staticcheck doesn't create GitHub Annotations #910
Comments
It works for me when using the following action instead:
The only relevant difference is that it's using setup-go@v1 instead of v2. (It also has to call the staticcheck binary directly, as setup-go@v1 didn't add $GOPATH/bin to the PATH, but that should not be important.) So, to me, this looks like a regression in the setup-go action. Looking at the difference between v1 and v2, the pattern they use to match output has changed from And indeed, the new pattern doesn't match our output. I'll try and file an issue with the setup-go people. |
I have sent actions/setup-go#98 |
Wow, very nice digging! |
Lacking any progress whatsoever in actions/setup-go, I now recommend using https://github.com/WillAbides/setup-go-faster instead, which is faster and has sensible problem matchers. |
I am going to close this. Upstream is being upstream, and setup-go-faster is a better alternative that works correctly. We'll mention it when we publish our article on running Staticcheck in CI. |
I'm looking for a way to have
staticcheck
create annotations on PRs, something like this:Running
staticcheck
in golangci-lint produces such annotations, but the standalone version doesn't.I created a minimal working example in
The GitHub Actions workflow is the following:
It does find the problem in my code (if you look at the linter output), but the PR is not annotated: https://github.com/marten-seemann/linter-test/pull/2/files
The text was updated successfully, but these errors were encountered: