Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip excessively large packages (binary assets) #703

Closed
dominikh opened this issue Mar 5, 2020 · 1 comment
Closed

Skip excessively large packages (binary assets) #703

dominikh opened this issue Mar 5, 2020 · 1 comment

Comments

@dominikh
Copy link
Owner

dominikh commented Mar 5, 2020

Extracted from #429 (comment):

Instead, we need a mechanism that skips packages entirely, and treats them as black boxes, only relying on the type information exposed by the compiler's export data. This will introduce some inaccuracy when analyzing dependents, and we must carefully evaluate whether this will lead to any false positives. The likelihood of that is low, however. Asset packages are unlikely to contain functions that act on control flow or otherwise modify the behavior of a program, other than providing binary data. Note, however, that we cannot do any better than this. We cannot ignore a package completely (that is, not even load its type information from export data), unless we also ignore all packages that depend on the package, recursively. Doing so seems undesirable to me.

I don't think, however, that handling this should require user intervention, i.e. an explicit list of packages to skip. We're well able to detect the size of files and skip packages that are absurdly large. We can also detect patterns common to asset generation without having to parse the file. I would rather focus my time on handling these cases automatically, than introduce a new knob that people need to discover first.

@dominikh dominikh added enhancement started Issues we've started working on labels Mar 5, 2020
@dominikh dominikh removed the started Issues we've started working on label May 8, 2020
@dominikh
Copy link
Owner Author

Closed by 3771fcc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant