Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot testing #2811

Open
martincostello opened this issue Apr 17, 2024 · 4 comments
Open

Snapshot testing #2811

martincostello opened this issue Apr 17, 2024 · 4 comments
Labels
help-wanted A change up for grabs for contributions from the community

Comments

@martincostello
Copy link
Collaborator

Consider adding tooling such as https://github.com/VerifyTests/Verify to create snapshot tests of generated schemas to provide a more comprehensive regression test suite.

@martincostello martincostello added the help-wanted A change up for grabs for contributions from the community label Apr 17, 2024
@SimonCropp
Copy link
Contributor

when u r using Verify, what would be the type of the instance you would pass in?

@SimonCropp
Copy link
Contributor

and the extension to Verify, do u want it under this org or the Verify org?

@martincostello
Copy link
Collaborator Author

when u r using Verify, what would be the type of the instance you would pass in?

I don't know, I haven't looked into it. At a high-level I was thinking of just comparing rendered JSON/YAML schemas.

@martincostello
Copy link
Collaborator Author

and the extension to Verify, do u want it under this org or the Verify org?

What extension? Also this repo isn't in an org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help-wanted A change up for grabs for contributions from the community
Projects
None yet
Development

No branches or pull requests

2 participants