Resolves a null pointer exception when returning a Dictionary containing known keys

[Eneuman]

This PR fixes a null pointer exception when having a API returning av Dictionary containing known keys
(ie a Dictionary<Enum, string>).

The problem was that the code tried to set schema.AdditionalProperties.Nullable without first checking if schema.AdditionalPropertiesAllowed was true. This resulted in a null point exception since schema.AdditionalProperties is null when schema.AdditionalPropertiesAllowed is false.

Fixes #2368

[Eneuman]

@domaindrivendev Ping :)

[jelical]

Hello, there @domaindrivendev :) Any news on this?

[sergey-litvinov]

@domaindrivendev is there any update on this PR and related issue? i'm having the same problem related to Dictionary and NRE during schema generation

[cezkc]

I just have the same problem here, using an example with
MapType<Dictionary<string, JToken>>(() => new OpenApiSchema { Example = new OpenApiObject { ["customerName"] = new OpenApiObject { ["+150000000000"] = new OpenApiString("Jon"), ["+160000000000"] = new OpenApiString("Doe"), ["default"] = new OpenApiString("there"), }, ["orderNumber"] = new OpenApiObject { ["+150000000000"] = new OpenApiString("1234"), ["+160000000000"] = new OpenApiString("4321"), ["default"] = new OpenApiString("0000"), }, }, Properties = new Dictionary<string, OpenApiSchema> { {"customerName", new OpenApiSchema{ Type="object" } }, {"orderNumber", new OpenApiSchema{ Type="object" } }, }, Type = "object" });

I had to add an empty AdditionalProperties to not throw an error again:
AdditionalProperties = new OpenApiSchema { }

Is there any fix for that? On previous versions (<=6.2.3) it was working fine

using
Swashbuckle.AspNetCore.SwaggerUI 6.3.1
Swashbuckle.AspNetCore.Annotations 6.3.1

[Eneuman]

@domaindrivendev ping

[tomhreb]

Hi @domaindrivendev, @JakubHolovsky -- any news on this please?

[plutora-steve-g]

The issue is still present in 6.4.0

[asmcpluss]

Any updates here?

[B-DAP]

bump

[jason-daly]

I just tripped over this issue after updating to 6.4.0. Would be nice to see it fixed.

[plachor]

Looking forward fix as well.

[fschick]

Same issue here. Can't update to 6.4.0.

[JakubHolovsky]

Hi @domaindrivendev, @JakubHolovsky -- any news on this please?

I am not the maintainer but trying to get all the attention to this so it finally gets merged. Stuck on older version here as well.

[sergei-lobanov]

@domaindrivendev hello, could you please approve this PR? We are all waiting months...

[hecerinc]

@domaindrivendev could we possibly get a release with this fix in? Thank you!

[angelaki]

Waiting for this fix, too. Soon deploy would be awesome!

[sguryev]

We have made Dictionary enum key nullable Dictionary<Enum?, Model> and SwaggerUI looks this way now

Waiting for the release 🤞🏼

[oyzar]

When will a version with this fix be released?

[vitaliy-orlov]

Waiting for this fix, too!