Support setting operation IDs from EndpointName metadata #2173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captainsafia
force-pushed
the
safia/op-id-from-group-name
branch
from
b4e6b78
to
8b22fbe
Compare
captainsafia
force-pushed
the
safia/op-id-from-group-name
branch
from
8b22fbe
to
05b3f45
Compare
captainsafia
commented
Jul 29, 2021
| // endpoint name if no route name is available. This allows us to | ||
| // generate operation IDs for endpoints that are defined using | ||
| // minimal APIs. | ||
| #if (!NETSTANDARD2_0) |
There was a problem hiding this comment.
This is ifdef'd out since the M.A.Routing 2.1.0 package does not contain the EndpointNameMetadata types that we need here. We could update the repo to rely on M.A.* 2.2.0 packages for everything if we wanted to avoid if-defing here but that seemed more appropriate for a separate PR.
|
quick ping to @domaindrivendev. @captainsafia can't apply labels or milestones but this is one of the minimal items we discussed. Thanks! |
captainsafia
commented
Jul 29, 2021
| #if (!NETSTANDARD2_0) | ||
| return | ||
| actionDescriptor.AttributeRouteInfo?.Name | ||
| ?? (actionDescriptor.EndpointMetadata.FirstOrDefault(m => m is EndpointNameMetadata) as EndpointNameMetadata)?.EndpointName; |
There was a problem hiding this comment.
We do FirstOrDefault here and not SingleOrDefault because of dotnet/aspnetcore#34199.
davidfowl
reviewed
Jul 29, 2021
test/Swashbuckle.AspNetCore.SwaggerGen.Test/SwaggerGenerator/SwaggerGeneratorTests.cs
Outdated
Show resolved
Hide resolved
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2165.
Part of dotnet/aspnetcore#34514.