Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed problem with finding nullable attribute in nested types because of roslyn optimizations #2056

Merged
merged 3 commits into from Mar 18, 2021

Conversation

Eneuman
Copy link
Contributor

@Eneuman Eneuman commented Mar 12, 2021

This change only affects the logic in finding compiler annotated null attributes when using the "SupportNonNullableReferenceTypes" option.

  • Adjusted code to handle roslyn compiler optimizations for nested types.
  • Fixed bug that cause a crash if annotation nullable attribute flag returned was byte[].
  • Added tests for compiler optimization senarios.
  • Added default values to test class to remove warnings.

More information about roslyn nullable metadata can be found here https://github.com/dotnet/roslyn/blob/main/docs/features/nullable-metadata.md

This PR should fix #2017 and probobly #1487

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6.0.5 subclass non-nullable strings shown as nullable
3 participants