Correction in docScroll #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Variable "node" leverages doc given by window instead of the one given as a parameter. Noticed when putting a popup into an iframe where the content of the iframe has quite some height.
|
|
|
Makes sense to me, looks like you are essentially fixing a "typo" in the old code. |
dylans
approved these changes
Sep 4, 2019
dylans
pushed a commit
that referenced
this pull request
Sep 4, 2019
Variable "node" leverages doc given by window instead of the one given as a parameter. Noticed when putting a popup into an iframe where the content of the iframe has quite some height. (cherry picked from commit 88c915f)
dylans
pushed a commit
that referenced
this pull request
Sep 4, 2019
Variable "node" leverages doc given by window instead of the one given as a parameter. Noticed when putting a popup into an iframe where the content of the iframe has quite some height. (cherry picked from commit 88c915f)
dylans
pushed a commit
that referenced
this pull request
Sep 4, 2019
Variable "node" leverages doc given by window instead of the one given as a parameter. Noticed when putting a popup into an iframe where the content of the iframe has quite some height. (cherry picked from commit 88c915f)
dylans
pushed a commit
that referenced
this pull request
Sep 4, 2019
Variable "node" leverages doc given by window instead of the one given as a parameter. Noticed when putting a popup into an iframe where the content of the iframe has quite some height. (cherry picked from commit 88c915f)
dylans
pushed a commit
that referenced
this pull request
Sep 4, 2019
Variable "node" leverages doc given by window instead of the one given as a parameter. Noticed when putting a popup into an iframe where the content of the iframe has quite some height. (cherry picked from commit 88c915f)
dylans
pushed a commit
that referenced
this pull request
Sep 4, 2019
Variable "node" leverages doc given by window instead of the one given as a parameter. Noticed when putting a popup into an iframe where the content of the iframe has quite some height. (cherry picked from commit 88c915f)
dylans
pushed a commit
that referenced
this pull request
Sep 4, 2019
Variable "node" leverages doc given by window instead of the one given as a parameter. Noticed when putting a popup into an iframe where the content of the iframe has quite some height. (cherry picked from commit 88c915f)
dylans
pushed a commit
that referenced
this pull request
Sep 4, 2019
Variable "node" leverages doc given by window instead of the one given as a parameter. Noticed when putting a popup into an iframe where the content of the iframe has quite some height. (cherry picked from commit 88c915f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variable "node" leverages doc given by window instead of the one given as a parameter. Noticed when putting a popup into an iframe where the content of the iframe has quite some height.