Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API /notifications.json has field ..._url but shows ..._path #5286

Open
BWindey opened this issue Jan 11, 2024 · 0 comments
Open

API /notifications.json has field ..._url but shows ..._path #5286

BWindey opened this issue Jan 11, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@BWindey
Copy link
Contributor

BWindey commented Jan 11, 2024

When looking at the output of dodona.be/notifications.json, I notice that the field "notifiable_url" does not contain a url, but a path (doesn't contain "https://dodona.be").
This is inconsistent with other json pages.

image
The 2 files that create the result:
https://github.com/dodona-edu/dodona/blob/main/app/views/notifications/_notification.json.jbuilder#3
https://github.com/dodona-edu/dodona/blob/main/app/helpers/notifications_helper.rb#9

@BWindey BWindey added the bug Something isn't working label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Unplanned
Development

Successfully merging a pull request may close this issue.

1 participant