Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript typings and possibly also Flow typings #222

Open
jgonggrijp opened this issue Jul 18, 2020 · 0 comments
Open

TypeScript typings and possibly also Flow typings #222

jgonggrijp opened this issue Jul 18, 2020 · 0 comments
Labels
after modules This should be postponed until after modularization (temporary label, see #220) enhancement

Comments

@jgonggrijp
Copy link
Contributor

It would be nice to have type declarations included within the repository and published to NPM, so that users don't need to rely on third-party type declarations (at least not for Contrib itself). This has been on @joshuacc's wish list but there was no ticket for it yet, at least not as far as I could tell.

I suggest to consider this a low priority enhancement. For maintenance reasons, it is probably best to wait with this at least until after #220 and DefinitelyTyped/DefinitelyTyped#45201.

A note to whoever might take up on this in the future: we have a convention in Underscore to write the source code proper in pure ES3 (with ES6 import/export for module linking only), so that it is ready to ship to all supported environments without any transpilation. I'd prefer to uphold this same convention in Contrib. So if you decide to add type declarations, please keep them separate from the source code proper.

(I don't mean to rule out that I might add the typings myself, by the way, but everyone is welcome to do it.)

@jgonggrijp jgonggrijp added the after modules This should be postponed until after modularization (temporary label, see #220) label Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
after modules This should be postponed until after modularization (temporary label, see #220) enhancement
Projects
None yet
Development

No branches or pull requests

1 participant