Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config template for PHPUnit >= 7.2 #7340

Merged
merged 1 commit into from Aug 8, 2018
Merged

Fix config template for PHPUnit >= 7.2 #7340

merged 1 commit into from Aug 8, 2018

Conversation

guilliamxavier
Copy link
Contributor

Merge duplicate <php> elements to fix

  Warning - The configuration file did not pass validation!
  The following problems have been detected:

  Line 44:
  - Element 'php': This element is not expected.

  Test results may not be as expected.

See sebastianbergmann/phpunit#3066

@Majkl578 Majkl578 added this to the 2.6.3 milestone Aug 8, 2018
@Majkl578 Majkl578 self-assigned this Aug 8, 2018
@Majkl578 Majkl578 changed the base branch from 2.6 to 2.7 August 8, 2018 18:05
@Majkl578 Majkl578 modified the milestones: 2.6.3, 3.0, 2.7.0 Aug 8, 2018
@Majkl578 Majkl578 merged commit 39609b8 into doctrine:2.7 Aug 8, 2018
@guilliamxavier guilliamxavier deleted the patch-1 branch August 9, 2018 07:28
@guilliamxavier
Copy link
Contributor Author

@Majkl578 Thanks for the merge, but why change the target branch to 2.7? I targeted 2.6 as a fix because 6b5eb11 had made phpunit.xml.dist invalid (according to the phpunit.xsd) even before it started to be validated programmatically (my XML editor was already flagging the error, for instance)

@Majkl578
Copy link
Contributor

Majkl578 commented Aug 9, 2018

2.6 is only using PHPUnit ^6.5 so it's not really affecting anything there. I expect 2.7 to be bumped to PHPUnit 7. (Want to submit a PR? 👍 )

Majkl578 added a commit that referenced this pull request Sep 23, 2018
Fix config template for PHPUnit >= 7.2
Majkl578 added a commit that referenced this pull request Nov 11, 2018
Fix config template for PHPUnit >= 7.2
lcobucci pushed a commit to lcobucci/doctrine2 that referenced this pull request Nov 21, 2018
Fix config template for PHPUnit >= 7.2
vilartoni added a commit to Emagister/doctrine-orm that referenced this pull request Jan 14, 2020
…gin-master

v2.7.0

[![Build Status](https://travis-ci.org/doctrine/orm.svg?branch=v2.7.0)](https://travis-ci.org/doctrine/orm)

This release solves Symfony 5.0 compatibility issues, some small improvements, and adds
various deprecation notices.

Please read carefully the [upgrade to 2.7
notes](https://github.com/doctrine/orm/blob/2.7/UPGRADE.md#upgrade-to-27) to know more
about the reasons and how to fix the deprecation messages.

---

- Total issues resolved: **1**
- Total pull requests resolved: **15**
- Total contributors: **10**

Deprecation
-----------

 - [7911: Be explicit about which Doctrine package in message](doctrine#7911) thanks to @lcobucci
 - [7909: Add deprecation messages](doctrine#7909) thanks to @lcobucci
 - [7901: Add deprecation warnings for 2.7.x](doctrine#7901) thanks to @lcobucci
 - [7701: Split and deprecate AbstractQuery#useResultCache()](doctrine#7701) thanks to @someniatko

CI
--

 - [7904: Make sure composer files are valid](doctrine#7904) thanks to @greg0ire
 - [7600: &doctrine#91;2.7&doctrine#93; CI: Test against PHP 7.4snapshot instead of nightly (8.0)](doctrine#7600) thanks to @Majkl578

Improvement
-----------

 - [7876: Fix compat of commands with Symfony 5](doctrine#7876) thanks to @nicolas-grekas
 - [7829: Skip Paginator LIMIT subquery and WHERE IN if query do not have LIMIT](doctrine#7829) thanks to @Seb33300
 - [7723: Allow Symfony 5.0](doctrine#7723) thanks to @nicolas-grekas
 - [7710: Prettified arrays in tool command orm:mapping:describe](doctrine#7710) thanks to @rtek
 - [7340: Fix config template for PHPUnit &gt;= 7.2](doctrine#7340) thanks to @guilliamxavier

BC Break,Improvement
--------------------

 - [7863: Paginator: Skip limit subquery if not required](doctrine#7863) thanks to @Seb33300

Documentation
-------------

 - [7382: Update homepage](doctrine#7382) thanks to @Majkl578

Bug
---

 - [7326: Cherry-pick doctrine#7307 to fix remaining usages of deprecated ClassLoader and Inflector from doctrine/common](doctrine#7326) thanks to @nicolas-grekas
 - [7079: Fix getJoinTableName for sqlite with schema attribute](doctrine#7079) thanks to @mairo744

BC Break,Deprecation,Improvement
--------------------------------

 - [6803: Deprecation of EntityManager copy method](doctrine#6803) thanks to @SenseException
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants