Adjust expectation #10239
Merged
Adjust expectation #10239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
force-pushed
the
adjust-expectations
branch
2 times, most recently
from
3a3c820
to
edf1b7c
Compare
composer.json
Outdated
| @@ -32,7 +32,7 @@ | |||
| "doctrine/inflector": "^1.4 || ^2.0", | |||
| "doctrine/instantiator": "^1.3", | |||
| "doctrine/lexer": "^1.2.3", | |||
| "doctrine/persistence": "^2.4 || ^3", | |||
| "doctrine/persistence": "^2.4 || ^3.1", | |||
There was a problem hiding this comment.
Shouldn't this 3.0 version skip at least happen in a minor release instead of a patch one?
There was a problem hiding this comment.
Sorry, I'll revert this, it's no longer necessary now that the test handles both cases.
RuntimePublicReflectionProperty has been deprecated in favor of RuntimeReflectionProperty. Let us use a more robust assertion.
greg0ire
force-pushed
the
adjust-expectations
branch
from
edf1b7c
to
ac334c8
Compare
derrabus
approved these changes
Nov 20, 2022
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Nov 20, 2022
* 2.13.x: Remove fragile assertions (doctrine#10239)
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Nov 20, 2022
* 2.14.x: Remove fragile assertions (doctrine#10239) update help for RunDqlCommand (doctrine#10233) Make the code easier to statically analyse Widen parameter type Document property as non-nullable
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Nov 20, 2022
* 2.14.x: Remove fragile assertions (doctrine#10239) update help for RunDqlCommand (doctrine#10233) Make the code easier to statically analyse Widen parameter type Document property as non-nullable
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Nov 20, 2022
* 2.13.x: Remove fragile assertions (doctrine#10239)
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Nov 20, 2022
* 2.14.x: Remove fragile assertions (doctrine#10239) update help for RunDqlCommand (doctrine#10233) Make the code easier to statically analyse Widen parameter type Document property as non-nullable
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Nov 20, 2022
* 2.14.x: Remove fragile assertions (doctrine#10239) update help for RunDqlCommand (doctrine#10233) Make the code easier to statically analyse Widen parameter type Document property as non-nullable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RuntimePublicReflectionPropertyhas been deprecated in favor ofRuntimeReflectionPropertyin doctrine/persistence#307.