Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Use neutral pronouns #8059

Merged
merged 1 commit into from Mar 6, 2020
Merged

Fix: Use neutral pronouns #8059

merged 1 commit into from Mar 6, 2020

Conversation

localheinz
Copy link
Contributor

This PR

  • uses gender-neutral pronouns in the documentation

@SenseException
Copy link
Member

Nice catch. Can you please rebase this PR to the 2.7 branch?

greg0ire
greg0ire previously approved these changes Mar 4, 2020
View reviewed changes
@localheinz localheinz changed the base branch from master to 2.7 March 4, 2020 23:35
@localheinz
Copy link
Contributor Author

@SenseException

Rebased!

greg0ire
greg0ire previously approved these changes Mar 4, 2020
View reviewed changes
SenseException
SenseException requested changes Mar 5, 2020
View reviewed changes
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I was too fast on that. There are other pronouncs to be fixed:

  • docs/en/reference/unitofwork.rst
    • "The developer can choose which kind of result he"
  • docs/en/tutorials/getting-started.rst
    • "A User can see all his reported or assigned Bugs"

SenseException
SenseException approved these changes Mar 6, 2020
View reviewed changes
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@SenseException SenseException merged commit eb70040 into doctrine:2.7 Mar 6, 2020
@localheinz localheinz deleted the fix/they branch March 6, 2020 16:27
@localheinz
Copy link
Contributor Author

Thank you, @greg0ire and @SenseException!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SenseException SenseException SenseException approved these changes

@greg0ire greg0ire greg0ire left review comments

Assignees
No one assigned
Labels
Documentation Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@localheinz @SenseException @greg0ire