Fix BC-break on underscore naming strategy #7908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We broke our BC promises on the last patch release by changing how the underscore naming strategy parses values with numbers. This commit makes it possible to configure whether or not to make the underscore naming strategy aware of numbers, keeping the old configuration as default value.
greg0ire
reviewed
Nov 18, 2019
greg0ire
approved these changes
Nov 18, 2019
|
@greg0ire thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We broke our BC promises on the last patch release by changing how the underscore naming strategy parses values with numbers.
This makes it possible to configure whether or not to make the underscore naming strategy aware of numbers, keeping the old configuration as default value.