New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention that lifecycle callbacks do not support Embeddables #7230
Conversation
@@ -240,6 +240,8 @@ a relevant lifecycle event. More than one callback can be defined for each | |||
lifecycle event. Lifecycle Callbacks are best used for simple operations | |||
specific to a particular entity class's lifecycle. | |||
|
|||
Note that Licecycle Callbacks can not be defined for Embeddables. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you use this syntax it will render it as a note box:
.. note::
Note that Licecycle Callbacks can not be defined for Embeddables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I saw it. I was not sure if it is that important to mention this. Anyhow, added it!
@jwage ping |
@jwage, can we wrap this up? |
Maybe a rebase would be a good idea. Also: Since this is from 2018, is the target branch master still the right choice? Do we need to have this in 2.7 by now? |
Done!
Well, I do not know what the rules are for this aspect. I do know it is only about one line of documentation so it can do little harm? |
There's AFAIK an upmerge strategy that lower branches will be merged with master. This way your contribution will appear in the other versions too. |
I rebased on 2.7 for you :) |
Just triggering the Travis build, I think I did things in the wrong order and the link was not established, now things look good :) |
Thanks @holtkamp ! |
As discussed in #6855