Fail nicely on enum FQCNs #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Mar 2, 2022
src/Doctrine/Instantiator/Exception/InvalidArgumentException.php
Outdated
Show resolved
Hide resolved
derrabus
force-pushed
the
improvement/fail-on-enum
branch
from
39c362a
to
227caa3
Compare
greg0ire
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When being presented with an enum FQCN, the
Instantiatorcurrently tries to create an instance via reflection and triggers anError. This PR turns this error into a niceDoctrine\Instantiator\Exception\InvalidArgumentExceptionwhich is the same exception we already get for interfaces, traits and abstract classes.An alternative could be to simply return the first case of the enum. The problem with that approach is that the instantiator currently guarantees that each call will yield a different instance. That wouldn't be the case for enums then.