Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse workflows from upstream and setup Psalm #87

Merged
merged 1 commit into from Oct 25, 2021
Merged

Reuse workflows from upstream and setup Psalm #87

merged 1 commit into from Oct 25, 2021

Conversation

greg0ire
Copy link
Member

No description provided.

SenseException
SenseException approved these changes Oct 25, 2021
View reviewed changes
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If ${{ matrix.php-version != '7.1' }} doesn't matter anymore then this is 👍

@greg0ire
Copy link
Member Author

It does matter, but it's handled upstream :)

@greg0ire greg0ire merged commit 39b9008 into doctrine:1.4.x Oct 25, 2021
@greg0ire greg0ire deleted the reuse-workflows branch October 25, 2021 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SenseException SenseException SenseException approved these changes

@beberlei beberlei Awaiting requested review from beberlei

@derrabus derrabus Awaiting requested review from derrabus

@malarzm malarzm Awaiting requested review from malarzm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@greg0ire @SenseException