Deprecate QueryBuilder APIs exposing its internal state #5551
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QueryBuilder::getState()
and the corresponding constants are absolutely irrelevant. They are used by the builder internally for tracking whether the previously generated SQL needs to be rebuilt. The state expressed as separate enum-like property is redundant since the$sql
property of the builder is nullable. Instead of marking the state as dirty, the builder can just set the value of$sql
toNULL
.QueryBuilder
API is aware of the type of the query being built since it's the one who calls theselect()
,insert()
, and the other methods defining the query type.