Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce property types in tests #5536

Merged
merged 1 commit into from Jul 25, 2022
Merged

Enforce property types in tests #5536

merged 1 commit into from Jul 25, 2022

Conversation

derrabus
Copy link
Member

Q A
Type improvement
Fixed issues N/A

Summary

On the 3.4.x branch, it should be safe to enforce native property types via PHPCS, the same way we already do this for parameter and return types.

@derrabus derrabus added this to the 3.4.0 milestone Jul 25, 2022
@derrabus derrabus requested a review from morozov July 25, 2022 17:51
@derrabus derrabus merged commit a5900ff into doctrine:3.4.x Jul 25, 2022
@derrabus derrabus deleted the cs/property-types-in-tests branch July 25, 2022 20:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@morozov morozov morozov approved these changes

Assignees
No one assigned
Labels
Static Analysis Test Suite
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@derrabus @morozov