Fix truncated oracle fetch result #4581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amenning
force-pushed
the
fix-oracle-truncated-fetch
branch
from
ff41757
to
dda2abd
Compare
morozov
reviewed
Apr 3, 2021
amenning
force-pushed
the
fix-oracle-truncated-fetch
branch
from
e842bea
to
09fd47f
Compare
morozov
reviewed
Apr 3, 2021
morozov
reviewed
Apr 3, 2021
morozov
reviewed
Apr 3, 2021
amenning
changed the title
morozov
reviewed
Apr 6, 2021
The error handler screens for oracle warnings from php oci8 driver and converts them to a truncated query result exception. This also adds a test that demonstrates the issue where a result set larger than the oci8 default prefetch value is queried, but a truncated row set is returned due to the dataset being invalidated during the fetch sequenece.
amenning
force-pushed
the
fix-oracle-truncated-fetch
branch
from
759356c
to
5bd5b4b
Compare
|
I removed that file from the commit and squashed them into one commit. All checks passed. |
morozov
approved these changes
Apr 10, 2021
|
Thanks, @amenning! |
|
Thank you for quick reviews and excellent guidance. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a test that demonstrates the issue where a result set
larger than the oci8 default prefetch value is queried, but a truncated
row set is returned due to the dataset being invalidated during the
fetch sequence. No php exception is thrown.