Dead code cleanup #91

hhamon · 2012-01-12T16:15:22Z

No description provided.

…ass.

…MasterSlaveConnection class.

…MsSqlPlatform class.

… class.

… in OraclePlatform class.

…eral methods of AbstractSchemaManager class.

…nager class.

…ass.

…ble class.

stof · 2012-01-12T16:30:56Z

lib/Doctrine/DBAL/Schema/Schema.php

@@ -214,7 +213,10 @@ public function renameTable($oldTableName, $newTableName)
    public function dropTable($tableName)
    {
        $tableName = strtolower($tableName);
-        $table = $this->getTable($tableName);
+        if (false === $this->hasTable($tableName)) {


if (!$this->hasTable()) ?

Yes I'm for this syntax but I don't know the CS for Doctrine. Do they use ! or false === ?

they use !, at least in most places (with spaces around it, contrary to Symfony)

Hum ok good to know :)

hhamon · 2012-01-12T17:07:08Z

Done I have renamed all AS to as :)

stof · 2012-01-12T17:13:05Z

@guilhermeblanco regarding as vs AS, @beberlei always use the uppercased one.

stof · 2012-01-12T17:13:44Z

lib/Doctrine/DBAL/Schema/Schema.php

@@ -123,8 +123,7 @@ public function getTables()
     */
    public function getTable($tableName)
    {
-        $tableName = strtolower($tableName);
-        if (!isset($this->_tables[$tableName])) {
+        if (false === $this->hasTable($tableName)) {


guilhermeblanco · 2012-01-12T19:00:37Z

@stof so @beberlei is wrong, because since the beginning we always used "as" (lowercased).

stof · 2012-01-12T19:01:54Z

@guilhermeblanco it's fine with me if you use the lowercased version. Simply take care to inform the lead developer :)

beberlei · 2012-01-22T00:15:47Z

this is clearly a conspiracy aiming to change my coding style. I will fight to the end ;)

beberlei · 2012-01-22T00:16:25Z

@hhamon i will merge this and the other PRs as soon as i get the 2.2 release out the door and have a bit more room.

hhamon · 2012-01-22T00:45:48Z

Great :)

@greg0ire

Release [2.10.2](https://github.com/doctrine/dbal/milestone/75) 2.10.2 ====== - Total issues resolved: **4** - Total pull requests resolved: **19** - Total contributors: **10** Improvement,Static Analysis --------------------------- - [3964: Mark every exception as immutable](doctrine#3964) thanks to @greg0ire CI,Improvement,Static Analysis ------------------------------ - [3961: Stop relying on the master version of Psalm](doctrine#3961) thanks to @greg0ire - [3951: Setup static analysis with Psalm](doctrine#3951) thanks to @greg0ire - [3799: Upgrade to PHPStan v0.12](doctrine#3799) thanks to @lcobucci Improvement,Logging,Test Suite ------------------------------ - [3957: Reworked LoggingTest to be able to test Statement::executeUpdate()](doctrine#3957) thanks to @morozov CI,Code Style,Improvement,Strict Typing --------------------------------------- - [3955: Remove baseline](doctrine#3955) thanks to @greg0ire Bug,SQLite,Schema Introspection,Schema Managers ----------------------------------------------- - [3937: Column comment incorrectly introspected on SQLite](doctrine#3937) thanks to @morozov Bug,Documentation,Prepared Statements,Query ------------------------------------------- - [3896: Updated documentation for QueryBuilder::execute() return value type](doctrine#3896) thanks to @morozov Bug,Prepared Statements ----------------------- - [3894: Make sure that the $types array has the same keys $params](doctrine#3894) thanks to @morozov - [3893: Ensure the constructor arguments are passed to custom classes](doctrine#3893) thanks to @duncan3dc - [3843: Fix unquoted stmt fragments backslash escaping](doctrine#3843) thanks to @morozov Documentation,Improvement ------------------------- - [3886: Update readme](doctrine#3886) thanks to @greg0ire - [3834: Fix docblock typos in DriverManager docs](doctrine#3834) thanks to @CHItA CI,Improvement,MariaDB,MySQL ---------------------------- - [3884: Use Docker consistently](doctrine#3884) thanks to @greg0ire - [3478: Improve readiness probe stability for containerized databases on CI](doctrine#3478) thanks to @morozov - [3883: Fix broken build](doctrine#3883) thanks to @greg0ire Bug,Documentation,Query,Query Limit/Offset Modification ------------------------------------------------------- - [3842: Fixed the QueryBuilder::setMaxResults() signature to accept NULL](doctrine#3842) thanks to @morozov Bug,Query --------- - [3832: Fix JOIN with no condition bug](doctrine#3832) thanks to @BenMorel Bug,PostgreSQL,Schema Introspection ----------------------------------- - [3821: &doctrine#91;pg&doctrine#93; fix getting table information if search&doctrine#95;path contains escaped schema name](doctrine#3821) thanks to @linniksa Documentation,Improvement,Logging --------------------------------- - [3812: Fix DebugStack#queries docblock type](doctrine#3812) thanks to @ostrolucky Bug,Regression,Schema --------------------- - [3790: fixed unqualified table name of fk constraints when using schemas](doctrine#3790) thanks to @stlrnz and @Alarich # gpg: Signature made Mon Apr 20 19:59:36 2020 # gpg: using DSA key 2C3A645671828132 # gpg: Can't check signature: public key not found # Conflicts: # README.md

@gjdanis

Release [2.11.0](https://github.com/doctrine/dbal/milestone/77) 2.11.0 ====== - Total issues resolved: **7** - Total pull requests resolved: **55** - Total contributors: **8** Improvement,Prepared Statements,SQL Server,Types,pdo_sqlsrv,sqlsrv ------------------------------------------------------------------ - [4274: Support ASCII parameter binding](doctrine#4274) thanks to @gjdanis Documentation ------------- - [4271: Add explanation about implicit indexes](doctrine#4271) thanks to @greg0ire Deprecation,Error Handling -------------------------- - [4253: Deprecate DBAL\DBALException in favor of DBAL\Exception](doctrine#4253) thanks to @morozov CI -- - [4251: Setup automatic release workflow](doctrine#4251) thanks to @greg0ire Deprecation,Schema Managers --------------------------- - [4230: Deprecate the functionality of dropping client connections when dropping a database](doctrine#4230) thanks to @morozov Deprecation,Platforms --------------------- - [4229: Deprecate more AbstractPlatform methods](doctrine#4229) thanks to @morozov - [4132: Deprecate AbstractPlatform::fixSchemaElementName()](doctrine#4132) thanks to @morozov Improvement,Test Suite ---------------------- - [4215: Remove test group configuration leftovers](doctrine#4215) thanks to @morozov - [4080: Update PHPUnit to 9.2](doctrine#4080) thanks to @morozov - [4079: Forward compatibility with PHPUnit 9.3](doctrine#4079) thanks to @morozov - [3923: Removed performance tests](doctrine#3923) thanks to @morozov Deprecation,Schema ------------------ - [4213: Deprecate the Synchronizer package](doctrine#4213) thanks to @morozov Blocker,Improvement,PHP,Test Suite ---------------------------------- - [4201: Update PHPUnit to 9.3](doctrine#4201) thanks to @morozov Blocker,PHP,Test Suite ---------------------- - [4196: The test suite uses the deprecated at() matcher](doctrine#4196) thanks to @morozov Connections,Deprecation,Documentation ------------------------------------- - [4175: Additional deprecation note for PrimaryReplicaConnection::query()](doctrine#4175) thanks to @morozov Connections,Deprecation,Prepared Statements ------------------------------------------- - [4165: Deprecated usage of wrapper components as implementations of driver-level interfaces](doctrine#4165) thanks to @morozov - [4020: Deprecated Connection::project(), Statement::errorCode() and errorInfo()](doctrine#4020) thanks to @morozov Connections,Deprecation ----------------------- - [4163: Deprecate duplicate and ambiguous wrapper connection methods](doctrine#4163) thanks to @morozov Error Handling,Improvement,Types -------------------------------- - [4145: Add TypeRegistry constructor](doctrine#4145) thanks to @morozov Deprecation,Drivers,Improvement,pdo_mysql,pdo_oci,pdo_pgsql,pdo_sqlite,pdo_sqlsrv --------------------------------------------------------------------------------- - [4144: Deprecate classes in Driver\PDO* namespaces](doctrine#4144) thanks to @morozov Connections,Documentation,Improvement ------------------------------------- - [4139: Mark connection constructors internal](doctrine#4139) thanks to @morozov Deprecation,Drivers,Error Handling ---------------------------------- - [4137: Deprecate driver exception conversion APIs](doctrine#4137) thanks to @morozov - [4112: Deprecate DriverException::getErrorCode()](doctrine#4112) thanks to @morozov Configuration,Connections,Deprecation,Error Handling ---------------------------------------------------- - [4134: Deprecate some DBALException factory methods](doctrine#4134) thanks to @morozov Code Style,Documentation ------------------------ - [4133: Fix more issues introduced by the deprecation of driver classes](doctrine#4133) thanks to @morozov BC Break,Drivers,Error Handling,pdo_sqlsrv,sqlsrv ------------------------------------------------- - [4131: Restore the PortWithoutHost exception parent class](doctrine#4131) thanks to @morozov Code Style,Improvement,Static Analysis -------------------------------------- - [4123: Remove the no longer needed error suppressions](doctrine#4123) thanks to @morozov Deprecation,Drivers,Error Handling,Improvement ---------------------------------------------- - [4118: Deprecate ExceptionConverterDriver](doctrine#4118) thanks to @morozov Bug,Connections,Improvement,Prepared Statements ----------------------------------------------- - [4117: Fixes for the recently introduced driver-level deprecations](doctrine#4117) thanks to @morozov Connections,Deprecation,Platform Detection ------------------------------------------ - [4114: Deprecate ServerInfoAwareConnection#requiresQueryForServerVersion() as an implementation detail](doctrine#4114) thanks to @morozov Deprecation,Prepared Statements,SQL Parser,oci8 ----------------------------------------------- - [4110: Mark non-interface OCI8 driver methods internal](doctrine#4110) thanks to @morozov Connections,Deprecation,Drivers,Improvement,Prepared Statements --------------------------------------------------------------- - [4100: Deprecate inconsistently and ambiguously named driver-level classes](doctrine#4100) thanks to @morozov Connections,Improvement ----------------------- - [4092: Remove Connection::$isConnected](doctrine#4092) thanks to @morozov Configuration,Connections ------------------------- - [4086: Mark Connection::getParams() internal](doctrine#4086) thanks to @morozov Bug,Drivers,ibm_db2 ------------------- - [4085: The IBM DB2 driver Exception class must implement the DriverException interface](doctrine#4085) thanks to @morozov PHP --- - [4078: Bump PHP requirement to 7.3 as of DBAL 2.11.0](doctrine#4078) thanks to @morozov Connections,Databases,Deprecation,Drivers ----------------------------------------- - [4068: Deprecate Driver::getDatabase()](doctrine#4068) thanks to @morozov Deprecation,Improvement,Portability ----------------------------------- - [4061: Deprecated platform-specific portability mode constants](doctrine#4061) thanks to @morozov - [4054: &doctrine#91;doctrineGH-4052&doctrine#93; Deprecate MasterSlaveConnection and rename to PrimaryReplicaConnection](doctrine#4054) thanks to @beberlei and @albe - [4017: Improve help of dbal:run-sql command](doctrine#4017) thanks to @ostrolucky Code Style,Improvement ---------------------- - [4050: Update doctrine/coding-standard to 8.0](doctrine#4050) thanks to @morozov Cache,Deprecation,Improvement,Prepared Statements ------------------------------------------------- - [4049: Replace forward-compatible ResultStatement interfaces with Result](doctrine#4049) thanks to @morozov Cache,Improvement,Prepared Statements ------------------------------------- - [4048: Make caching layer not rely on closeCursor()](doctrine#4048) thanks to @morozov Deprecation,Improvement,Prepared Statements ------------------------------------------- - [4037: Introduce Statement::fetchFirstColumn()](doctrine#4037) thanks to @morozov - [4019: Deprecated the concept of the fetch mode](doctrine#4019) thanks to @morozov Bug,Documentation,Improvement,Prepared Statements ------------------------------------------------- - [4034: Additional changes based on the discussion in doctrine#4007](doctrine#4034) thanks to @morozov Connections,Console,Improvement ------------------------------- - [3956: allow using multiple connections for CLI commands](doctrine#3956) thanks to @dmaicher Deprecation,Logging ------------------- - [3935: Deprecate EchoSQLLogger](doctrine#3935) thanks to @morozov Improvement,Packaging --------------------- - [3924: Actualize the content of the .gitattributes file](doctrine#3924) thanks to @morozov Azure,Deprecation,Drivers,Drizzle,MariaDB,Platforms,PostgreSQL,SQL Anywhere,SQL Server,Sharding,pdo_ibm ------------------------------------------------------------------------------------------------------- - [3905: Deprecate the usage of the legacy platforms and drivers](doctrine#3905) thanks to @morozov Deprecation,Query ----------------- - [3864: CompositeExpression and()/or() factory methods](doctrine#3864) thanks to @BenMorel - [3853: Deprecate calling QueryBuilder methods with an array argument](doctrine#3853) thanks to @BenMorel and @morozov Deprecation,Tools ----------------- - [3861: Deprecated the usage of the Version class](doctrine#3861) thanks to @morozov Improvement,Query ----------------- - [3852: First parameter of ExpressionBuilder::and/or() mandatory](doctrine#3852) thanks to @BenMorel Deprecation,Improvement,Query ----------------------------- - [3851: Rename andX() / orX() methods](doctrine#3851) thanks to @BenMorel - [3850: Prepare CompositeExpression for immutability](doctrine#3850) thanks to @BenMorel # gpg: Signature made Mon Sep 21 01:47:31 2020 # gpg: using DSA key 1BEDEE0A820BC30D858F9F0C2C3A645671828132 # gpg: Can't check signature: No public key # Conflicts: # README.md # lib/Doctrine/DBAL/Driver/AbstractOracleDriver.php # lib/Doctrine/DBAL/Driver/OCI8/Driver.php # lib/Doctrine/DBAL/Version.php

@BenMorel

Release [2.12.0](https://github.com/doctrine/dbal/milestone/82) 2.12.0 ====== - Total issues resolved: **1** - Total pull requests resolved: **7** - Total contributors: **5** Documentation,Static Analysis ----------------------------- - [4376: Configuration should not be internal](doctrine#4376) thanks to @BenMorel CI -- - [4374: Reduce number of build jobs](doctrine#4374) thanks to @greg0ire - [4365: Fail on extension / tool installation failure](doctrine#4365) thanks to @greg0ire Bug,Static Analysis ------------------- - [4373: Psalm fails on release commits](doctrine#4373) thanks to @morozov Documentation,Error Handling ---------------------------- - [4362: Adds exception thrown by execute() method](doctrine#4362) thanks to @toby-griffiths CI,PHP ------ - [4361: Test all extensions with PHP8](doctrine#4361) thanks to @greg0ire PHP --- - [4347: &doctrine#91;2.12&doctrine#93; PHP 8 compatibility](doctrine#4347) thanks to @derrabus # gpg: Signature made Thu Oct 22 20:29:24 2020 # gpg: using DSA key 1BEDEE0A820BC30D858F9F0C2C3A645671828132 # gpg: Can't check signature: No public key

Hugo Hamon added 13 commits January 12, 2012 16:16

[Connection] removed unused local variable $position in Connection cl…

17c22e1

…ass.

[Connection] removed unused local variables $index and $fieldName in …

30f0195

…MasterSlaveConnection class.

[Platforms] removed unused local variables $index_ and $fieldName in …

62876eb

…MsSqlPlatform class.

[Platforms] removed unused local variable $fieldName in MysqlPlatform…

78f2a20

… class.

[Platforms] removed unused local variables $indexName and $definition…

a8b9f89

… in OraclePlatform class.

[DBAL] removed unused local variable $token in SQLParserUtils class.

750036e

[Schema] removed all occurrences of unused local variable $key in sev…

196cbef

…eral methods of AbstractSchemaManager class.

[Schema] removed unused local variable $candidate in Comparator class.

b672e95

[Schema] removed unused local variable $tableIndexRows in DB2SchemaMa…

24e9573

…nager class.

[Schema] removed unused local variable $def in MysqlSchemaManager class.

5dc01e7

[Schema] removed unused local variable $key in OracleSchemaManager cl…

5cfc064

…ass.

[Schema] removed unused local variables $column and $columnName in Ta…

ad22cc4

…ble class.

[Schema] fixed CS.

7207664

stof reviewed Jan 12, 2012
View reviewed changes

[DBAL] fixed some CS and renamed all "AS" keywords to "as".

e35cf23

stof reviewed Jan 12, 2012
View reviewed changes

[Schema] fixed CS.

897b635

beberlei closed this in a8019c6 Mar 24, 2012

github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dead code cleanup #91

Dead code cleanup #91

hhamon commented Jan 12, 2012

stof Jan 12, 2012

hhamon Jan 12, 2012

stof Jan 12, 2012

hhamon Jan 12, 2012

hhamon commented Jan 12, 2012

stof commented Jan 12, 2012

stof Jan 12, 2012

hhamon Jan 12, 2012

guilhermeblanco commented Jan 12, 2012

stof commented Jan 12, 2012

beberlei commented Jan 22, 2012

beberlei commented Jan 22, 2012

hhamon commented Jan 22, 2012

Dead code cleanup #91

Dead code cleanup #91

Conversation

hhamon commented Jan 12, 2012

stof Jan 12, 2012

Choose a reason for hiding this comment

hhamon Jan 12, 2012

Choose a reason for hiding this comment

stof Jan 12, 2012

Choose a reason for hiding this comment

hhamon Jan 12, 2012

Choose a reason for hiding this comment

hhamon commented Jan 12, 2012

stof commented Jan 12, 2012

stof Jan 12, 2012

Choose a reason for hiding this comment

hhamon Jan 12, 2012

Choose a reason for hiding this comment

guilhermeblanco commented Jan 12, 2012

stof commented Jan 12, 2012

beberlei commented Jan 22, 2012

beberlei commented Jan 22, 2012

hhamon commented Jan 22, 2012