Why do you begin a transaction in your commit method?!

[mica16]

Bug Report

Using Doctrine 3.7.2 and Symfony 6.3.

Summary

In the EntityManager.php file, we have the wrapInTransactionmethod:

https://github.com/doctrine/orm/blob/e585a92763612455f591b44cf0482d9852cc5fc0/lib/Doctrine/ORM/EntityManager.php#L267-L284

Inside the code of $this->conn->commit() we can find that at the very end of the method:

dbal/src/Connection.php

Lines 1442 to 1448 in 6a793fb

	if ($this->autoCommit !== false || $this->transactionNestingLevel !== 0) {
	return $result;
	}
	$this->beginTransaction();
	return $result;

Why to declare a nested transaction at the end without ever closing it?

Current behaviour

I noticed that when I run my integration tests, warning about "Nested Transactions..."
I was "forced" to declare "use_savepoints: true" in my doctrine.yaml.

How to reproduce

Don't declare use_savepoints: true in doctrine.yaml and run an integration test using wrapInTransaction.

Expected behaviour

Don't declare a useless nested transaction.

[greg0ire]

Ah actually, the second code block is in doctrine/dbal, let's transfer the issue back!

[greg0ire]

And to answer your question, this is done in auto-commit mode: https://www.doctrine-project.org/projects/doctrine-dbal/en/3.7/reference/transactions.html#auto-commit-mode

The new transaction is not nested, since we are inside commit(), as explained in the comment: // commits transaction and immediately starts a new one

[bassilil]

cod done?