Do not treat deprecation level as errors #5566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
force-pushed
the
serialization-deprecation
branch
from
293da73
to
d6e5d7d
Compare
|
@wouterj the patch looks good. Please add a corresponding unit test. |
wouterj
force-pushed
the
serialization-deprecation
branch
from
d6e5d7d
to
c66b982
Compare
|
Thanks for the quick response. I've added a test (I couldn't find Doctrine's standard regarding fixture objects, please let me know if I should place it in a different location). |
derrabus
approved these changes
Aug 5, 2022
|
Thanks, @wouterj! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When testing our application on PHP 8.1, we noticed Doctrine fails hard on the deprecation notice about
Serialization::unserialize(). As we cannot upgrade to__unserialize()quickly (we returned a custom string representation), we cannot fix this deprecation at the moment (instead, we'll always serialize using theserialize()format, and let all entries update over time).Doctrine treating deprecations as a hard unserialization error is blocking this process. I believe it should ignore deprecations and let the PHP handler handle them.