Add MariaDB 10.7 to the build matrix #5327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
commented
Mar 20, 2022
| $table->addColumn('foo', 'text')->setPlatformOption('charset', 'ascii'); | ||
| $table->addColumn('bar', 'text')->setPlatformOption('charset', 'latin1'); | ||
| $this->schemaManager->dropAndCreateTable($table); | ||
|
|
||
| $columns = $this->schemaManager->listTableColumns('test_column_charset'); | ||
|
|
||
| self::assertFalse($columns['id']->hasPlatformOption('charset')); | ||
| self::assertEquals('utf8', $columns['no_charset']->getPlatformOption('charset')); |
There was a problem hiding this comment.
This assertion was removed in #4644 as well. In this test, we don't care what charset the database uses by default.
morozov
commented
Mar 20, 2022
| $table->addOption('charset', 'latin1'); | ||
| $table->addColumn('id', 'integer'); | ||
| $table->addColumn('text', 'text'); | ||
| $table->addColumn('foo', 'text')->setPlatformOption('collation', 'latin1_swedish_ci'); | ||
| $table->addColumn('bar', 'text')->setPlatformOption('collation', 'utf8_general_ci'); | ||
| $table->addColumn('bar', 'text')->setPlatformOption('collation', 'utf8mb4_general_ci'); |
There was a problem hiding this comment.
From the documentation:
MariaDB 10.6,
utf8is an alias forutf8mb3.
In order to test schema introspection, we should use a charset that isn't an alias so that it's introspected as is.
morozov
commented
Mar 20, 2022
| ENGINE InnoDB | ||
| ROW_FORMAT COMPRESSED |
There was a problem hiding this comment.
This causes the following error on MariaDB 10.7:
InnoDB refuses to write tables with ROW_FORMAT=COMPRESSED or KEY_BLOCK_SIZE.
When testing schema introspection, we don't care about the specific value of the row format, so we can use any other valid value.
derrabus
approved these changes
Mar 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5010.